handle more corner cases in displayNavigationButton

steamysips · May 31, 2024 · b073d0c · b073d0c
1 parent fba4a7f
commit b073d0c
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/views/Pagination.php b/src/views/Pagination.php
@@ -45,7 +45,11 @@ function displayNavigationButton(int $current_page_number, int $total_pages, str
     $link_content = htmlspecialchars($is_left ? "<" : ">");
     $className = "page-item";
 
-    if (($current_page_number <= 1 && $is_left) || ($current_page_number >= $total_pages && !$is_left)) {
+    if (($current_page_number > $total_pages) || // invalid page number
+        ($current_page_number < 1) || // invalid page number
+        ($current_page_number === 1 && $is_left) || // first page
+        ($current_page_number === $total_pages && !$is_left) // last page
+    ) {
         $className .= " disabled";
     }