Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up tests and change revive formatter #711

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Conversation

adambabik
Copy link
Collaborator

No description provided.

@@ -102,7 +102,7 @@ lint:
@gofumpt -d .
@revive \
-config revive.toml \
-formatter stylish \
-formatter friendly \
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The friendly formatter allows click-and-open functionality in terminals.

Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@sourishkrout sourishkrout merged commit 4827c98 into main Dec 2, 2024
5 checks passed
@sourishkrout sourishkrout deleted the adamb/clean-up branch December 2, 2024 18:57
Copy link

sonarqubecloud bot commented Dec 2, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants