Made arguments to functions in run injected through vm and not code.

[orizi]

No description provided.

[piotmag769]

Just to make sure I understand it correctly: the header with segments initalization and function call is still appended, just not the args, rights?

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware and @ilyalesokhin-starkware)

[orizi]

yes - the args (including the gas builtin) are just not a part of the code - but their size is allocated in code, and the VM fills them.

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware and @ilyalesokhin-starkware)

[lotem-starkware]

This change is 

[ilyalesokhin-starkware]

crates/cairo-lang-runner/src/lib.rs line 672 at r1 (raw file):

                let offset = ap_offset - used_args;
                for _ in 0..*ty_size {
                    casm_extend!(ctx, [ap + 0] = [ap - offset], ap++;);

can't you put the ap_offset += params_size; before the builtins instead of copying the parameters??

Code quote:

casm_extend!(ctx, [ap + 0] = [ap - offset], ap++;);

[ilyalesokhin-starkware]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @orizi)

[orizi]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @ilyalesokhin-starkware)

---

crates/cairo-lang-runner/src/lib.rs line 672 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

can't you put the ap_offset += params_size; before the builtins instead of copying the parameters??

checking if knowing where to inject the params is easy on the other side.
but in general - does it matter here? in reality we do need something like that for the actual runnable format - won't we?

[ilyalesokhin-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)

[ilyalesokhin-starkware]

crates/cairo-lang-runner/src/lib.rs line 651 at r1 (raw file):

        let mut used_args = 0;
        for ty in param_types {
            let (generic_ty, ty_size) = ty;

Suggestion:

        for (generic_ty, ty_size) in param_types {

[ilyalesokhin-starkware]

crates/cairo-lang-runner/src/lib.rs line 671 at r1 (raw file):

            } else {
                let offset = ap_offset - used_args;
                for _ in 0..*ty_size {

do you support a param that is not a felt on an array?
size > 1?

Code quote:

ty_size

[ilyalesokhin-starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware and @orizi)

[orizi]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware and @ilyalesokhin-starkware)

---

crates/cairo-lang-runner/src/lib.rs line 651 at r1 (raw file):

        let mut used_args = 0;
        for ty in param_types {
            let (generic_ty, ty_size) = ty;

Done.

---

crates/cairo-lang-runner/src/lib.rs line 671 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

do you support a param that is not a felt on an array?
size > 1?

yes - structs that hold multiple such elements fully work.

[ilyalesokhin-starkware]

Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @gilbens-starkware and @piotmag769)