-
Notifications
You must be signed in to change notification settings - Fork 45
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix:
ftm::Debug
impl fails to compile
The `ftm::Debug` impl fails to compile unless the `alloc` feature is on. The underlying math lib allows `alloc`-free hex output, except it's not fixed-width like the current impl does. This technically changes the debug output format, but it should be worth it for getting to avoid requiring `alloc` for just debug printing. Also adds a GitHub Actions workflow to check that all feature combinations would compile correctly so that this doesn't happen again.
- Loading branch information
1 parent
3204933
commit c8c6a69
Showing
3 changed files
with
42 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
on: | ||
push: | ||
branches: | ||
- "main" | ||
pull_request: | ||
|
||
name: "Build feature combinations" | ||
|
||
jobs: | ||
feature-powerset: | ||
name: "Build ${{ matrix.package }} features" | ||
runs-on: "ubuntu-latest" | ||
|
||
strategy: | ||
matrix: | ||
package: | ||
- "starknet-types-core" | ||
- "starknet-types-rpc" | ||
|
||
steps: | ||
- name: "Checkout source code" | ||
uses: "actions/checkout@v3" | ||
|
||
- name: "Setup stable toolchain" | ||
uses: "actions-rs/toolchain@v1" | ||
with: | ||
toolchain: "stable" | ||
profile: "minimal" | ||
override: true | ||
|
||
- name: "Install cargo-hack" | ||
run: | | ||
cargo install --locked cargo-hack | ||
- name: "Build all feature combinations" | ||
run: | | ||
cargo hack build --package ${{ matrix.package }} --feature-powerset |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters