chore: code dedup in felt from bigint

starknet-io · Sep 22, 2024 · 21ec015 · 21ec015
1 parent b13ccec
commit 21ec015
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/crates/starknet-types-core/src/felt/mod.rs b/crates/starknet-types-core/src/felt/mod.rs
@@ -574,15 +574,10 @@ impl From<&BigInt> for Felt {
 
 impl From<BigInt> for Felt {
     fn from(bigint: BigInt) -> Felt {
-        let (sign, bytes) = bigint.to_bytes_le();
-        let felt = Felt::from_bytes_le_slice(&bytes);
-        if sign == Sign::Minus {
-            felt.neg()
-        } else {
-            felt
-        }
+        Self::from(&bigint)
     }
 }
+
 impl From<&BigUint> for Felt {
     fn from(biguint: &BigUint) -> Felt {
         Felt::from_bytes_le_slice(&biguint.to_bytes_le())
@@ -591,7 +586,7 @@ impl From<&BigUint> for Felt {
 
 impl From<BigUint> for Felt {
     fn from(biguint: BigUint) -> Felt {
-        Felt::from_bytes_le_slice(&biguint.to_bytes_le())
+        Self::from(&biguint)
     }
 }