Contact + Message API fixes #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overriding serialize method for labels so saving a message works (it requires a list of ids, so when we save and it gives us a list of hashes it blows up) Use same type for folder and labels
jpcamara
force-pushed
the
message-and-contact-api-fixes
branch
from
35b8adf to
9f8db50
Compare
Fix for saving a partial address
Add value variable back
Che-Chris
force-pushed
the
message-and-contact-api-fixes
branch
from
5b24ab4 to
cb66650
Compare
Add raw_json back for events
Add missing attributes to timespan
… version Downloading as a temp file actually does not work, but in lieu of rewriting that for now we are allowing a download of the raw content which can be handled down the line instead
Add raw file download
Override save method to exclude the object field in when
* If you do, it causes the API to 500 on updates
Che-Chris
force-pushed
the
message-and-contact-api-fixes
branch
2 times, most recently
from
b823396 to
a018d0c
Compare
jpcamara
force-pushed
the
message-and-contact-api-fixes
branch
from
a018d0c to
a2f77b6
Compare
* This is to hot fix a production issue where a field that is supposed to be a list is sometimes coming back as a string
* Won't be used, but will fix our gem
* Pull in change from main nylas gem repo to ignore attribute changes: nylas@ba9bd56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding source to contact to better support contact api
Overriding serialize method for labels so saving a message works (it requires a list of ids, so when we save and it gives us a list of hashes it blows up)
Adds tracking to drafts
to_h always returns the attribute value as long as it's not nil, so we can clear fields in an update
Don't save before sending draft to send directly
Removed unused
web_pagefrom contactsExclude sending
objectinwhenwhen saving an event