-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change relation matching to case-insensitive #141
Conversation
@bachng2017 build is failing because of code style settings. Please do create a changelog entry Your submission should be accompanied by corresponding tests. |
ed7f517
to
15db463
Compare
@findinpath we fixed code style and added a test. Should the checks run automatically ? |
ic.
|
@bachng2017 because you are a 1st time commiter the build workflow needs to be approved manually. Pls squash the commits and use the same commit mesaage guidelines as in Trino development |
Issue with Starburst tests will be resolved by #139. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % comments
We should add a follow up story to remove this override when Trino supports case insensitive quoted identifiers.
thanks @mdesmet for the review and fixes :) |
@findinpath , is there any guideline for this ? Should I rebase all the commit into 1 ?
|
@mdesmet can you pls reference a Trino open issue if there is any? |
8b5336b
to
e3a19ad
Compare
063d502
to
15520b3
Compare
Thanks for your contribution! |
Follow up issue created: #144 |
Overview
This is a resolve for #140
The implement will override the compare function in the BaseRelation to use case-insensitive match as default.
Checklist
README.md
updated and added information about my changechangie new
to create a changelog entry