feat(dspy): extend incomplete generations #1613
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okhat
reviewed
Oct 11, 2024
There was a problem hiding this comment.
Just to double check: this file is not being changed materially right? Just formatting?
There was a problem hiding this comment.
one change in this file - added a comment
mikeedjones
commented
Oct 11, 2024
| demos=demos, | ||
| inputs=inputs, | ||
| _parse_values=_parse_values, | ||
| max_extensions=dspy.settings.max_extensions or 0, |
There was a problem hiding this comment.
@okhat this is the only real change in this file - everything else is linting/formatting from rust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the output parsed by
ChatAdapter.parsedoes not include all the fields required by the signature, the lm will be called again up tomax_extensionstimes, with the thus-far completed output added to the input fields for the next generation.Logic is wrapped up as a decorator to allow the logic to be reused by future
Adapers.Added tests for extended generation.
max_extensionsdefaults to 1 to maintain current behaviour.Linting and formatting changes from ruff.