feat: refactor settings to new Settings cog and implement admin/non-a… #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rassl
reviewed
Nov 14, 2023
kevkevinpal
reviewed
Nov 15, 2023
|
Changing display in 'settings' shouldn't change the display on the graph. This will be used in the future to set the default view: |
|
Also, when I tap 'Admin', this doesn't trigger the admin settings. @Rassl maybe you can add the hardcode for now like other areas? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #394
Refactor settings functionality: move settings to Settings cog and implement admin/non-admin settings
Checks: