Fix: Node Update API Payload Structure and Data Handling #2596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tomsmith8, @Rassl, Please review this PR. |
Rassl
reviewed
Jan 6, 2025
Rassl
reviewed
Jan 7, 2025
src/stores/useDataStore/index.ts
Outdated
| updateNode: (updatedNode) => { | ||
| console.info(updatedNode) | ||
| updateNode: (updatedNode: NodeExtended) => { | ||
| set((state) => { |
There was a problem hiding this comment.
const { nodesNormalized } = get()
nodesNormalized.set(...)
set({ nodeNormalized })
dm me if I missing something
There was a problem hiding this comment.
@Rassl Please review again
aliraza556
force-pushed
the
fix/node-update-payload-structure
branch
from
e7c0f88 to
ddc3109
Compare
Rassl
approved these changes
Jan 7, 2025
|
@aliraza556 when I change the value, the new key value pairs are not passed into the PUT request. I chnaged Kevin to kevkevin: PUT request: |
|
all the properties with their new value from the modal should be passed into the properties object. And the frontend state should be updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket №: #2593
closes #2593
Evidance:
https://www.loom.com/share/152eaeb867a44eef87c878dc50c12435