Fixed[Blue-Graph]: Enable 'Confirm' Button When Attribute is Deleted #2558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tomsmith8, @Rassl, Please review this PR. |
Rassl
reviewed
Jan 2, 2025
| @@ -303,6 +303,7 @@ export const Editor = ({ | |||
|
|
|||
| const handleDeleteAttribute = (attributeKey: string) => { | |||
| setDeletedAttributes((prev) => [...prev, attributeKey]) | |||
| setSubmitDisabled(false) | |||
There was a problem hiding this comment.
we have several checks for controlling, submitDisabled status, which is already bad, adding one more is not good, use one of the existing. Basically we need to check if something changed
Rassl
requested changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
closes: #2554
Issue ticket number and link:
Evidence:
https://www.loom.com/share/654f6309fbda4647a3904046bfb5d4cf