Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollout update strategy annotation #817

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WnP
Copy link

@WnP WnP commented Dec 27, 2024

Related to #591 and #724.

Since #724, the Rollout update strategy has been changed from "rollout" to "restart". While I can understand that this may be useful in some scenarios, it may not be expected in others.

This MR gives the user the flexibility to choose between a "rollout" or "restart" strategy using an annotation.

@MuneebAijaz
Copy link
Contributor

https://github.com/stakater/Reloader/pull/771/files there is a PR already, we were waiting for tests to be added. If you can pursue/add tests via your PR, we can merge yours and close the other one.

@WnP WnP force-pushed the rollout-strategy-annotation branch from 9488163 to 143c535 Compare January 2, 2025 15:39
@WnP
Copy link
Author

WnP commented Jan 2, 2025

Hi @MuneebAijaz,

Of course, I've updated my PR with some unit tests.

During the process I've changed testutil.getObjectMeta to be able to pass some annotations.

I've also removed some log lines:

-       logrus.Warnf("Before: %+v", rolloutBefore.Spec.Template.Spec.Containers[0].Env)
-       logrus.Warnf("After: %+v", rollout.Spec.Template.Spec.Containers[0].Env)

And the api call to retrieve rolloutBefore.

Signed-off-by: Steeve Chailloux <[email protected]>
@WnP WnP force-pushed the rollout-strategy-annotation branch from 1d44618 to d45054b Compare January 13, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants