Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase config.rs coverage #329

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Increase config.rs coverage #329

wants to merge 1 commit into from

Conversation

CAGS295
Copy link
Contributor

@CAGS295 CAGS295 commented Oct 27, 2023

Summary of Changes

Line coverage diff:
3.92% (4/102) -> 46.00% (46/100)

Testing

Risks

How were these changes tested?

What future testing should occur?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f3606db) 43.71% compared to head (adf3389) 44.31%.
Report is 5 commits behind head on main.

Files Patch % Lines
romeo/src/stacks_client.rs 0.00% 2 Missing ⚠️
romeo/src/main.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
+ Coverage   43.71%   44.31%   +0.60%     
==========================================
  Files          45       45              
  Lines        5433     5465      +32     
  Branches       47       47              
==========================================
+ Hits         2375     2422      +47     
+ Misses       3057     3042      -15     
  Partials        1        1              
Flag Coverage Δ
unittests 76.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CAGS295 CAGS295 marked this pull request as ready for review October 27, 2023 18:23
@CAGS295 CAGS295 self-assigned this Nov 9, 2023
@CLAassistant
Copy link

CLAassistant commented Nov 16, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Triage
Development

Successfully merging this pull request may close these issues.

2 participants