Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postgresflex user fixes #70

Merged
merged 11 commits into from
Feb 8, 2024
Merged

Postgresflex user fixes #70

merged 11 commits into from
Feb 8, 2024

Conversation

hcsa73
Copy link
Contributor

@hcsa73 hcsa73 commented Feb 8, 2024 •
edited
Loading

  • Fix roles available
  • Make --username flag required on creation
  • Change --roles flag name to --role
  • Remove incorrect UUID check of user ID
  • Add check for args, check if args aren't empty

joaopalet
joaopalet reviewed Feb 8, 2024
View reviewed changes
internal/cmd/mongodbflex/user/create/create.go Outdated Show resolved Hide resolved
internal/cmd/postgresflex/user/delete/delete.go Show resolved Hide resolved
internal/pkg/args/args.go Outdated Show resolved Hide resolved
internal/cmd/postgresflex/user/create/create.go Outdated Show resolved Hide resolved
@hcsa73 hcsa73 merged commit 0ce9f70 into main Feb 8, 2024
1 check passed
@hcsa73 hcsa73 deleted the hs/fix/postgresflex-user branch February 8, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaopalet joaopalet joaopalet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hcsa73 @joaopalet