Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move global flags to common flags package #21

Merged
merged 6 commits into from
Nov 23, 2023
Merged

Conversation

hcsa73
Copy link
Contributor

@hcsa73 hcsa73 commented Nov 23, 2023

  • Created commonflags package, which has global flags, handles configuring them and getting their value
  • Removed testutils package, which is made redundant by commonflags.ConfigureFlags

@hcsa73 hcsa73 force-pushed the hs/global-flags-package branch from 79eb658 to 0ec9f47 Compare November 23, 2023 16:18
internal/pkg/commonflags/common_flags.go Outdated Show resolved Hide resolved
internal/pkg/commonflags/common_flags.go Outdated Show resolved Hide resolved
internal/pkg/commonflags/common_flags.go Outdated Show resolved Hide resolved
@hcsa73 hcsa73 merged commit 7c4949a into main Nov 23, 2023
1 check passed
@hcsa73 hcsa73 deleted the hs/global-flags-package branch November 23, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants