Implement --limit flag on list commands

internal/cmd/dns/record-set/list/list.go

@@ -22,6 +22,7 @@ const (
 	nameLikeFlag    = "name-like"
 	activeFlag      = "is-active"
 	orderByNameFlag = "order-by-name"
+	limitFlag       = "limit"
 )
 
 type flagModel struct {
@@ -30,6 +31,7 @@ type flagModel struct {
 	NameLike    *string
 	Active      *bool
 	OrderByName *string
+	Limit       *int64
 }
 
 func NewCmd() *cobra.Command {
@@ -63,6 +65,11 @@ func NewCmd() *cobra.Command {
 				return nil
 			}
 
+			// Truncate output
+			if model.Limit != nil && len(recordSets) > int(*model.Limit) {
+				recordSets = recordSets[:*model.Limit]
+			}
+
 			// Show output as table
 			table := tables.NewTable()
 			table.SetHeader("ID", "Name", "Type", "State")
@@ -75,6 +82,7 @@ func NewCmd() *cobra.Command {
 			return nil
 		},
 	}
+
 	configureFlags(cmd)
 	return cmd
 }
@@ -87,6 +95,7 @@ func configureFlags(cmd *cobra.Command) {
 	cmd.Flags().String(nameLikeFlag, "", "Filter by name")
 	cmd.Flags().Var(flags.EnumBoolFlag(), activeFlag, fmt.Sprintf("Filter by active status, one of %q", activeFlagOptions))
 	cmd.Flags().Var(flags.EnumFlag(true, orderByNameFlagOptions...), orderByNameFlag, fmt.Sprintf("Order by name, one of %q", orderByNameFlagOptions))
+	cmd.Flags().Int64(limitFlag, 0, "Maximum number of entries to list")
 
 	err := utils.MarkFlagsRequired(cmd, zoneIdFlag)
 	cobra.CheckErr(err)
@@ -98,12 +107,18 @@ func parseFlags(cmd *cobra.Command) (*flagModel, error) {
 		return nil, fmt.Errorf("project ID not set")
 	}
 
+	limit := utils.FlagToInt64Pointer(cmd, limitFlag)
+	if limit != nil && *limit < 1 {
+		return nil, fmt.Errorf("limit must be greater than 0")
+	}
+
 	return &flagModel{
 		ProjectId:   projectId,
 		ZoneId:      utils.FlagToStringValue(cmd, zoneIdFlag),
 		NameLike:    utils.FlagToStringPointer(cmd, nameLikeFlag),
 		Active:      utils.FlagToBoolPointer(cmd, activeFlag),
 		OrderByName: utils.FlagToStringPointer(cmd, orderByNameFlag),
+		Limit:       utils.FlagToInt64Pointer(cmd, limitFlag),
 	}, nil
 }
 

internal/cmd/dns/record-set/list/list_test.go

@@ -29,6 +29,7 @@ func fixtureFlagValues(mods ...func(flagValues map[string]string)) map[string]st
 		nameLikeFlag:    "some-pattern",
 		activeFlag:      "true",
 		orderByNameFlag: "asc",
+		limitFlag:       "10",
 	}
 	for _, mod := range mods {
 		mod(flagValues)
@@ -43,6 +44,7 @@ func fixtureFlagModel(mods ...func(model *flagModel)) *flagModel {
 		NameLike:    utils.Ptr("some-pattern"),
 		Active:      utils.Ptr(true),
 		OrderByName: utils.Ptr("asc"),
+		Limit:       utils.Ptr(int64(10)),
 	}
 	for _, mod := range mods {
 		mod(model)
@@ -170,6 +172,20 @@ func TestParseFlags(t *testing.T) {
 			}),
 			isValid: false,
 		},
+		{
+			description: "limit invalid",
+			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
+				flagValues[limitFlag] = "invalid"
+			}),
+			isValid: false,
+		},
+		{
+			description: "limit invalid 2",
+			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
+				flagValues[limitFlag] = "0"
+			}),
+			isValid: false,
+		},
 	}
 
 	for _, tt := range tests {

internal/cmd/dns/zone/list/list.go

@@ -21,13 +21,15 @@ const (
 	nameLikeFlag    = "name-like"
 	activeFlag      = "is-active"
 	orderByNameFlag = "order-by-name"
+	limitFlag       = "limit"
 )
 
 type flagModel struct {
 	ProjectId   string
 	NameLike    *string
 	Active      *bool
 	OrderByName *string
+	Limit       *int64
 }
 
 func NewCmd() *cobra.Command {
@@ -61,6 +63,11 @@ func NewCmd() *cobra.Command {
 				return nil
 			}
 
+			// Truncate output
+			if model.Limit != nil && len(zones) > int(*model.Limit) {
+				zones = zones[:*model.Limit]
+			}
+
 			// Show output as table
 			table := tables.NewTable()
 			table.SetHeader("ID", "NAME", "DNS_NAME", "STATE")
@@ -84,6 +91,7 @@ func configureFlags(cmd *cobra.Command) {
 	cmd.Flags().String(nameLikeFlag, "", "Filter by name")
 	cmd.Flags().Var(flags.EnumBoolFlag(), activeFlag, fmt.Sprintf("Filter by active status, one of %q", activeFlagOptions))
 	cmd.Flags().Var(flags.EnumFlag(true, orderByNameFlagOptions...), orderByNameFlag, fmt.Sprintf("Order by name, one of %q", orderByNameFlagOptions))
+	cmd.Flags().Int64(limitFlag, 0, "Maximum number of entries to list")
 }
 
 func parseFlags(cmd *cobra.Command) (*flagModel, error) {
@@ -92,11 +100,17 @@ func parseFlags(cmd *cobra.Command) (*flagModel, error) {
 		return nil, fmt.Errorf("project ID not set")
 	}
 
+	limit := utils.FlagToInt64Pointer(cmd, limitFlag)
+	if limit != nil && *limit < 1 {
+		return nil, fmt.Errorf("limit must be greater than 0")
+	}
+
 	return &flagModel{
 		ProjectId:   projectId,
 		NameLike:    utils.FlagToStringPointer(cmd, nameLikeFlag),
 		Active:      utils.FlagToBoolPointer(cmd, activeFlag),
 		OrderByName: utils.FlagToStringPointer(cmd, orderByNameFlag),
+		Limit:       limit,
 	}, nil
 }
 

internal/cmd/dns/zone/list/list_test.go

@@ -27,6 +27,7 @@ func fixtureFlagValues(mods ...func(flagValues map[string]string)) map[string]st
 		nameLikeFlag:    "some-pattern",
 		activeFlag:      "true",
 		orderByNameFlag: "asc",
+		limitFlag:       "10",
 	}
 	for _, mod := range mods {
 		mod(flagValues)
@@ -40,6 +41,7 @@ func fixtureFlagModel(mods ...func(model *flagModel)) *flagModel {
 		NameLike:    utils.Ptr("some-pattern"),
 		Active:      utils.Ptr(true),
 		OrderByName: utils.Ptr("asc"),
+		Limit:       utils.Ptr(int64(10)),
 	}
 	for _, mod := range mods {
 		mod(model)
@@ -165,6 +167,20 @@ func TestParseFlags(t *testing.T) {
 			}),
 			isValid: false,
 		},
+		{
+			description: "limit invalid",
+			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
+				flagValues[limitFlag] = "invalid"
+			}),
+			isValid: false,
+		},
+		{
+			description: "limit invalid 2",
+			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
+				flagValues[limitFlag] = "0"
+			}),
+			isValid: false,
+		},
 	}
 
 	for _, tt := range tests {

internal/cmd/postgresql/credential/list/list.go

@@ -18,11 +18,13 @@ import (
 const (
 	projectIdFlag  = "project-id"
 	instanceIdFlag = "instance-id"
+	limitFlag      = "limit"
 )
 
 type flagModel struct {
 	ProjectId  string
 	InstanceId string
+	Limit      *int64
 }
 
 func NewCmd() *cobra.Command {
@@ -56,6 +58,11 @@ func NewCmd() *cobra.Command {
 				return nil
 			}
 
+			// Truncate output
+			if model.Limit != nil && len(credentials) > int(*model.Limit) {
+				credentials = credentials[:*model.Limit]
+			}
+
 			// Show output as table
 			table := tables.NewTable()
 			table.SetHeader("ID")
@@ -74,6 +81,7 @@ func NewCmd() *cobra.Command {
 
 func configureFlags(cmd *cobra.Command) {
 	cmd.Flags().Var(flags.UUIDFlag(), instanceIdFlag, "Instance ID")
+	cmd.Flags().Int64(limitFlag, 0, "Maximum number of entries to list")
 
 	err := utils.MarkFlagsRequired(cmd, instanceIdFlag)
 	cobra.CheckErr(err)
@@ -85,9 +93,15 @@ func parseFlags(cmd *cobra.Command) (*flagModel, error) {
 		return nil, fmt.Errorf("project ID not set")
 	}
 
+	limit := utils.FlagToInt64Pointer(cmd, limitFlag)
+	if limit != nil && *limit < 1 {
+		return nil, fmt.Errorf("limit must be greater than 0")
+	}
+
 	return &flagModel{
 		ProjectId:  projectId,
 		InstanceId: utils.FlagToStringValue(cmd, instanceIdFlag),
+		Limit:      limit,
 	}, nil
 }
 

internal/cmd/postgresql/credential/list/list_test.go

@@ -6,6 +6,7 @@ import (
 
 	"github.com/stackitcloud/stackit-cli/internal/pkg/config"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/testutils"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/utils"
 
 	"github.com/google/go-cmp/cmp"
 	"github.com/google/go-cmp/cmp/cmpopts"
@@ -25,6 +26,7 @@ func fixtureFlagValues(mods ...func(flagValues map[string]string)) map[string]st
 	flagValues := map[string]string{
 		projectIdFlag:  testProjectId,
 		instanceIdFlag: testInstanceId,
+		limitFlag:      "10",
 	}
 	for _, mod := range mods {
 		mod(flagValues)
@@ -36,6 +38,7 @@ func fixtureFlagModel(mods ...func(model *flagModel)) *flagModel {
 	model := &flagModel{
 		ProjectId:  testProjectId,
 		InstanceId: testInstanceId,
+		Limit:      utils.Ptr(int64(10)),
 	}
 	for _, mod := range mods {
 		mod(model)
@@ -111,6 +114,20 @@ func TestParseFlags(t *testing.T) {
 			}),
 			isValid: false,
 		},
+		{
+			description: "limit invalid",
+			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
+				flagValues[limitFlag] = "invalid"
+			}),
+			isValid: false,
+		},
+		{
+			description: "limit invalid 2",
+			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
+				flagValues[limitFlag] = "0"
+			}),
+			isValid: false,
+		},
 	}
 
 	for _, tt := range tests {

internal/cmd/postgresql/instance/list/list.go

@@ -7,14 +7,20 @@ import (
 	"github.com/stackitcloud/stackit-cli/internal/pkg/config"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/services/postgresql/client"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/tables"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/utils"
 
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
 	"github.com/stackitcloud/stackit-sdk-go/services/postgresql"
 )
 
+const (
+	limitFlag = "limit"
+)
+
 type flagModel struct {
 	ProjectId string
+	Limit     *int64
 }
 
 func NewCmd() *cobra.Command {
@@ -48,6 +54,11 @@ func NewCmd() *cobra.Command {
 				return nil
 			}
 
+			// Truncate output
+			if model.Limit != nil && len(instances) > int(*model.Limit) {
+				instances = instances[:*model.Limit]
+			}
+
 			// Show output as table
 			table := tables.NewTable()
 			table.SetHeader("ID", "NAME", "LAST_OPERATION.TYPE", "LAST_OPERATION.STATE")
@@ -60,17 +71,29 @@ func NewCmd() *cobra.Command {
 			return nil
 		},
 	}
+
+	configureFlags(cmd)
 	return cmd
 }
 
-func parseFlags(_ *cobra.Command) (*flagModel, error) {
+func configureFlags(cmd *cobra.Command) {
+	cmd.Flags().Int64(limitFlag, 0, "Maximum number of entries to list")
+}
+
+func parseFlags(cmd *cobra.Command) (*flagModel, error) {
 	projectId := viper.GetString(config.ProjectIdKey)
 	if projectId == "" {
 		return nil, fmt.Errorf("project ID not set")
 	}
 
+	limit := utils.FlagToInt64Pointer(cmd, limitFlag)
+	if limit != nil && *limit < 1 {
+		return nil, fmt.Errorf("limit must be greater than 0")
+	}
+
 	return &flagModel{
 		ProjectId: projectId,
+		Limit:     utils.FlagToInt64Pointer(cmd, limitFlag),
 	}, nil
 }