Onboard Secrets Manager (ACLs): fix test cases after update on main (#…

…173)
stackitcloud · Mar 21, 2024 · ca553ac · ca553ac
1 parent deff194
commit ca553ac
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/internal/cmd/secrets-manager/instance/create/create_test.go b/internal/cmd/secrets-manager/instance/create/create_test.go
@@ -95,13 +95,15 @@ func TestParseInput(t *testing.T) {
 			flagValues: map[string]string{
 				projectIdFlag:    testProjectId,
 				instanceNameFlag: "",
+				aclFlag:          "",
 			},
 			isValid: true,
 			expectedModel: &inputModel{
 				GlobalFlagModel: &globalflags.GlobalFlagModel{
 					ProjectId: testProjectId,
 				},
 				InstanceName: utils.Ptr(""),
+				Acls:         &[]string{},
 			},
 		},
 		{
@@ -121,13 +123,6 @@ func TestParseInput(t *testing.T) {
 				model.Acls = nil
 			}),
 		},
-		{
-			description: "acl empty",
-			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
-				flagValues[aclFlag] = ""
-			}),
-			isValid: false,
-		},
 		{
 			description: "repeated acl flags",
 			flagValues:  fixtureFlagValues(),

diff --git a/internal/cmd/secrets-manager/instance/update/update_test.go b/internal/cmd/secrets-manager/instance/update/update_test.go
@@ -127,7 +127,10 @@ func TestParseInput(t *testing.T) {
 				projectIdFlag: testProjectId,
 				aclFlag:       "",
 			},
-			isValid: false,
+			isValid: true,
+			expectedModel: fixtureInputModel(func(model *inputModel) {
+				model.Acls = &[]string{}
+			}),
 		},
 		{
 			description: "project id missing",