Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: README.md - fix secret name #70

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

csautter
Copy link

@csautter csautter commented Dec 17, 2024

Copy and pasting the current docs does not lead to a successful installation of the helm chart if you use the <STACKIT AUTH TOKEN>.

You have to change the helm value to meet the kubectl command stackitSaAuthentication.secretName = "stackit-cert-manager-webhook".

As an alternative i would propose a consistent naming for both secret types as it is treaded equal in the helm chart.

Copy and pasting the current docs does not lead to a successful installation of the helm chart if you use the <STACKIT AUTH TOKEN>.

You have to change the helm value to meet the kubectl command `stackitSaAuthentication.secretName = "stackit-cert-manager-webhook"`.

As an alternative i would propose a consistent naming for both secret types as it is treaded equal in the helm chart.
@csautter csautter requested a review from fsandel as a code owner December 17, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant