Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Chart appVersion #63

Merged
merged 2 commits into from
Dec 5, 2024
Merged

fix: Chart appVersion #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a93ab5
Update codeowners
slm0n87 Dec 4, 2024
bef6454
Fix chart appVersion
slm0n87 Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Release
on:
push:
tags:
- "*"
- "v*"

permissions: read-all

Expand Down
6 changes: 3 additions & 3 deletions CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
* patrick.koss@mail.schwarz
* patrick.koss@stackit.cloud
* [email protected]
* simon.stier@mail.schwarz
* [email protected]
* simon.stier@stackit.cloud
* [email protected]
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,5 +234,5 @@ For those interested in the Helm chart creation mechanics, the process was facil
helm package deploy/stackit
```

To release a new version of the Helm chart, one must meticulously update the version delineation in the
To release a new version of the Helm chart, one must meticulously update the appVersion and (chart)version delineation in the
[Chart.yaml](./deploy/stackit/Chart.yaml). Post this modification, initiate a new release to encompass these changes.
6 changes: 3 additions & 3 deletions deploy/stackit/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
apiVersion: v1
appVersion: "1.0"
description: A Helm chart for Kubernetes
appVersion: "v0.3.1"
description: A Helm chart for stackitcloud/stackit-cert-manager-webhook
name: stackit-cert-manager-webhook
version: 0.3.2
version: 0.3.3
2 changes: 1 addition & 1 deletion deploy/stackit/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ spec:
serviceAccountName: {{ include "stackit-cert-manager-webhook.fullname" . }}
containers:
- name: {{ .Chart.Name }}
image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
args:
- --tls-cert-file=/tls/tls.crt
Expand Down
4 changes: 2 additions & 2 deletions deploy/stackit/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ certManager:
image:
# -- repository of the image.
repository: ghcr.io/stackitcloud/stackit-cert-manager-webhook
# -- tag of the image.
tag: v0.3.1
# Overrides the image tag whose default is {{ .Chart.AppVersion }}
tag: ""
# -- pull policy of the image.
pullPolicy: IfNotPresent

Expand Down
Loading