Pass region to all openstack clients #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MichaelEischer: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ske-prow
bot
added
the
size/M
MichaelEischer
force-pushed
the
fix-region
branch
from
33717a5 to
5c21ec5
Compare
ske-prow
bot
added
size/XS
MichaelEischer
force-pushed
the
fix-region
branch
from
955500b to
e470699
Compare
ske-prow
bot
removed
the
needs-rebase
hown3d
approved these changes
Jun 20, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hown3d The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: abc5e63749aaa5c39c1cfd1673786b12f79d3d52
|
ske-prow
bot
added
the
approved
Duciwuci
pushed a commit
that referenced
this pull request
Jun 24, 2024
* create openstack clients with region * extract region for remaining clients * fix tests
Duciwuci
pushed a commit
that referenced
this pull request
Jun 24, 2024
* create openstack clients with region * extract region for remaining clients * fix tests
Duciwuci
pushed a commit
that referenced
this pull request
Jun 24, 2024
* create openstack clients with region * extract region for remaining clients * fix tests
Duciwuci
pushed a commit
that referenced
this pull request
Jun 24, 2024
* create openstack clients with region * extract region for remaining clients * fix tests
Duciwuci
pushed a commit
that referenced
this pull request
Jun 24, 2024
* create openstack clients with region * extract region for remaining clients * fix tests
Duciwuci
pushed a commit
that referenced
this pull request
Jun 24, 2024
* create openstack clients with region * extract region for remaining clients * fix tests
Duciwuci
pushed a commit
that referenced
this pull request
Jun 24, 2024
* create openstack clients with region * extract region for remaining clients * fix tests
ske-prow bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
* Fix cloud provider config tenant name is being phased out in favor of project name (#30) * Allow disabling service controller Possibility to disable service controllers in cloud controller manager * Increase liveness probe timeouts for ccm * Expose additional metrics for CSI components * Increase timeout CSI probes and retry interval * Decrease log level for CSI attacher * Adjust resources for CSI driver * Allow custom DNS in Openstack providerConfig * Cherry-pick useExistingSubnet feature (10-01-2024) add SubnetID to APIs (15bdb26) implement 'use existing subnet' for terraform (8fac4ae) implement 'use existing subnet' for infraflow (80f0836) extend integration tests (3678da4) extend infrastructureConfig validation (fa83256) extend configValidator (547389c) * Skip Loadbalancer Calls during deletion * Remove ControlPlane healthchecks (#52) * Configure OWNERS for ske prow (#55) * Use args in Deployment (#56) * Pass region to all openstack clients (#57) * create openstack clients with region * extract region for remaining clients * fix tests --------- Co-authored-by: einfachnuralex <[email protected]> Co-authored-by: Kai Kummerer <[email protected]> Co-authored-by: Marcel Boehm <[email protected]> Co-authored-by: Maximilian Geberl <[email protected]> Co-authored-by: Michael Eischer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind bug
/area control-plane
/platform openstack
What this PR does / why we need it:
Pass region to all openstack client factories. This is required once multiple regions show up in the openstack service catalog.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: