Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter error #54

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Fix linter error #54

merged 1 commit into from
Jun 13, 2024

Conversation

MichaelEischer
Copy link
Collaborator

How to categorize this PR?

/kind bug
/area control-plane
/platform openstack

What this PR does / why we need it:

Fix linter error.

@Duciwuci
Copy link
Collaborator

/lgtm

@MichaelEischer
Copy link
Collaborator Author

/approve

@ske-prow
Copy link

ske-prow bot commented Jun 13, 2024

@Duciwuci: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ske-prow ske-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 13, 2024
@Duciwuci
Copy link
Collaborator

/lgtm

@ske-prow
Copy link

ske-prow bot commented Jun 13, 2024

@Duciwuci: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Duciwuci
Copy link
Collaborator

/kind bug

@ske-prow
Copy link

ske-prow bot commented Jun 13, 2024

@Duciwuci: The label(s) kind/bug cannot be applied, because the repository doesn't have them.

In response to this:

/kind bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@MichaelEischer
Copy link
Collaborator Author

/lgtm

@ske-prow
Copy link

ske-prow bot commented Jun 13, 2024

@MichaelEischer: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@MichaelEischer
Copy link
Collaborator Author

/approve

@ske-prow ske-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2024
@Duciwuci
Copy link
Collaborator

/lgtm

@ske-prow
Copy link

ske-prow bot commented Jun 13, 2024

@Duciwuci: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hown3d
Copy link

hown3d commented Jun 13, 2024

/lgtm
/approve

@ske-prow ske-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2024
@ske-prow
Copy link

ske-prow bot commented Jun 13, 2024

LGTM label has been added.

Git tree hash: a0f667843aedcde70b1660e0e0a5e28aac58efd0

@ske-prow
Copy link

ske-prow bot commented Jun 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Duciwuci, hown3d, MichaelEischer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MichaelEischer,hown3d]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Duciwuci
Copy link
Collaborator

/lgtm

@ske-prow
Copy link

ske-prow bot commented Jun 13, 2024

@Duciwuci: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Duciwuci
Copy link
Collaborator

/lgtm

@ske-prow ske-prow bot merged commit 7460d3f into ske-v1.38 Jun 13, 2024
6 checks passed
@ske-prow ske-prow bot deleted the fix-linter-errors branch June 13, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants