Committee as entry point #493
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Filter shares for slot `CommitteeRunner` based on validators that have duty for that slot. * Filter duty and create share map according to owned validators * Add test: start duty with no shares for duty's validators * Add test: happy flow for committee with fraction of duty's validators * Generate JSON tests * Apply suggestions --------- Co-authored-by: MatheusFranco99 <[email protected]>
* Update go1.20 to go1.22 * Update go.sum with mod tidy
* Update dependencies * Fix lint issue * Generate JSON tests to trigger actions * Update fastssz * Generate JSON tests and align ssz error * Revert go-eth2-client version change * Revert fastssz upgrade * Generate SSZ and JSON tests
* Solve potential file inclusion via variable * Fix file permission (0644 to 0600) * Add nosec comment for PRNG (pseudo-random number generator) used for testing * Fix lint issue on nil check in []byte type * Update permission from 0444 to 0600 * Update 0444 to 0400
* Remove nolint comment and export timeout variables * Drop unnecessary nolint * Add comment * Fix lint issue
* Add share length validation in runner construction * Align to error handling in runners constructions * Add validation to committee runner * Add runner construction tests * Refactor runner construction in testingutil to deal with creation errors * Generate JSON tests * Fix lint issue * Fix comments
* Remove redundant validation * Align error string
* Sort signers in decided message * Add test for sorted signers in decided msg * Generate JSON tests * Fix lint issue
* Stop processing consensus messages after instance is decided * Align error in qbft tests * Align errors in ssv tests * Generate JSON tests * Fix lint issue
* Remove leftover err check * Align argument variable name to type
…nstead of a single Validator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR makes the
Committeestructure the entry point in theSSVmodule.Before, we had both
CommitteeandValidatoras distinct entry points. Now,CommitteeholdsValidatorobjects and redirects messages and duty-start events to the appropriate validator object.Extra changes
As refactoring, this PR also:
ValidatorstructureProcessMessagefunction existent inCommitteeandValidatorto a unique one to avoid duplicated knowledgeAdded tests
Note
For the test case of a message with
MessageIDthat doesn't belong to either the committee or to a validator, we already had theWrongMessageIDtest. Thus, we simply aligned the error string.Closes #451