Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QBFT tests leftovers - Commit, Controller - Decided, Prepare, Proposal, Round-Change #327

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

QBFT tests leftovers - Commit, Controller - Decided, Prepare, Proposal, Round-Change #327

wants to merge 9 commits into from

Conversation

MatheusFranco99
Copy link
Contributor

@MatheusFranco99 MatheusFranco99 commented Dec 27, 2023 •
edited
Loading

Tests

Commit

  • Decided full data
  • Invalid full data - Since the commit validation doesn't check the FullData field, it produces no error. Should I include a check, discard this test or just leave it?
  • Valid full data - Commit validation doesn't check the FullData field, so why this test?

Controller - Decided

  • Valid full data

Prepare

  • Duplicate message quorum
  • Set prepared full data

Proposal

  • Valid full data

Round Change

  • Invalid Justification Full Data
  • Valid Justification Full Data

@MatheusFranco99 MatheusFranco99 marked this pull request as ready for review December 29, 2023 18:03
@MatheusFranco99 MatheusFranco99 self-assigned this Dec 29, 2023
@MatheusFranco99 MatheusFranco99 changed the title QBFT tests leftovers QBFT tests leftovers - Commit, Controller - Decided, Prepare, Proposal, Round-Change Dec 29, 2023
@MatheusFranco99
Copy link
Contributor Author

The test "Set prepared full data" was dropped because it's already tested in the happy flow test.

#327 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GalRogozinski GalRogozinski GalRogozinski approved these changes

@MatusKysel MatusKysel MatusKysel approved these changes

@y0sher y0sher Awaiting requested review from y0sher

At least 3 approving reviews are required to merge this pull request.

Assignees

@MatheusFranco99 MatheusFranco99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MatheusFranco99 @MatusKysel @GalRogozinski