Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build template, rule paths & modules #112

Merged
merged 33 commits into from
Nov 3, 2019
Merged

build template, rule paths & modules #112

merged 33 commits into from
Nov 3, 2019

Conversation

ssube
Copy link
Owner

@ssube ssube commented Nov 2, 2019 •
edited
Loading

@codecov
Copy link

codecov bot commented Nov 2, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@b3c66dc). Click here to learn what that means.
The diff coverage is 54.62%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #112   +/-   ##
=========================================
  Coverage          ?   64.28%           
=========================================
  Files             ?       17           
  Lines             ?      224           
  Branches          ?       33           
=========================================
  Hits              ?      144           
  Misses            ?       65           
  Partials          ?       15
Impacted Files Coverage Δ
src/config/index.ts 77.77% <100%> (ø)
src/utils/index.ts 100% <100%> (ø)
src/rule/index.ts 45.31% <45.31%> (ø)
src/visitor/VisitorContext.ts 77.77% <50%> (ø)
src/source.ts 28.57% <50%> (ø)
src/utils/ajv/index.ts 50% <50%> (ø)
src/config/args.ts 50% <54.54%> (ø)
src/rule/SchemaRule.ts 76.92% <76.92%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3c66dc...f6bc739. Read the comment docs.

@ssube ssube changed the title build template & make cleanup build template, rule paths & modules Nov 2, 2019
@ssube
fix: move completion into main, remove weird exit from arg parsing
09902c5
@ssube
fix(rules): remove redundant rule field from result
b624cda 
the value of the rule field is always this and it is unused by the
visitor.
@ssube
fix(rules): group rule errors to trigger correct failure (#114)
62fe73a
@ssube
fix(tests): add gitlab CI test snippet, move test snippets into test dir
f2c923a
@ssube
fix(visitor): remove error method from context
eac8f61 
BREAKING CHANGE: rule errors must be grouped and returned in the rule
result, fixing #114 and keeping the context immutable.
@ssube
fix(rules): filter gitlab jobs better
66e6963 
list other top-level keys and replace the patternProperties filter
with additionalProperties to prevent top-level keys from being
validated as jobs (which they will fail)
@ssube
fix(docs): note pretty-printing logs
55ec71c
@ssube ssube merged commit 8ab6bb2 into master Nov 3, 2019
@ssube ssube mentioned this pull request Nov 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isolex isolex[bot] isolex[bot] approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

streamed errors do not cause rule failure load rules from directory load rule modules
1 participant
@ssube