Pull request - Spell check and data-file name uniformization #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Stan,
Here is a pull request for (1) fixing some very minor spell errors, but also for (2) uniformizing the data-file name for the Cisco sensors which currently have a name based on their SNMP host (%snmp-host%), while other data files use the system ID (%system-id%).
I see no side effects with (1). But (2) may introduce some historical data loss when a Torrus admin upgrade from a previous version... I let you decide whether this is worth the change or not.
Best regards,
Yann