replace table writer with go-pretty #2292

[hyposcaler-bot]

@hellt for #2292 Lightly tested, but should be functional enough to judge if you like the change.

[hyposcaler-bot]

I was just targeting the replacement, tried to stick with the original logic that was there.

[kaelemc]

@hyposcaler-bot Tried it out for the fun of it.. Looks good.

[hyposcaler-bot]

Some smoke tests related to the inspect are failing, need to get a handle on the smoke tests, having some issued getting them to run locally on my machine. Then will poke and see what's up.

[hellt]

Sounds good. If time permits I'll check the PR on my flight today

If anything I will take care of the tests later as well

[hellt]

Re tests. The devcontainer should handle them I hope.
And there is some documentation around it https://containerlab.dev/manual/dev/test/

[hyposcaler-bot]

Re tests. The devcontainer should handle them I hope.

Mostly does, but I get some failures locally on the tests, that don't seem to fail when github runs them.

For the failures when github runs the smoke test, think they are just failing because of the difference between │ and | when it goes to split the output of the inspect.

[hellt]

Yes, the failures are definitely about the table border char
Perhaps the test should have a car that keeps the border char to make it easily adaptable

[hyposcaler-bot]

Think I have the smoke tests sorted, added a ${table-delimit} set to │ for the appropriate robot tests.