-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use default vCPU and RAM settings from vrnetlab #2285
base: main
Are you sure you want to change the base?
Conversation
Cisco docs say that XRv9k requires 4vCPU. This greatly improves the boot time and performance of the node.
It seems like it would be best to have a single source of the default cpu/mem settings between clab and vrnetlab If memory serves me well, keeping it in the vrnetlab makes more sense like this hellt/vrnetlab#261 And then every VR node might have the same default set for their respective constructor class, while clab has a way to overwrite it via env vars |
Sounds good, so I should remove the env vars from the clab end so that they are only passed when the user manually sets them? Just want to be absolutely crystal clear :) |
"VCPU": "4", | ||
"RAM": "16384", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As simple as removing these two lines I guess?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but first ensuring that the vrnetlab has these defaults set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep gotcha 👍
I'll make the changes on the vrnetlab side (maybe after the scrapli work is finished) then make the changes on the containerlab end. |
2vCPU is frankly not enough for this node. Cisco docs say 4vCPU is the minimum required, with 4 vCPU I am seeing greatly improved boot times (still absurdly long though 😁).
https://www.cisco.com/c/en/us/td/docs/routers/virtual-routers/configuration/guide/b-xrv9k-cg/b-xrv9k-cg_chapter_011.html