Fix missing scroll in query box #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Martín <[email protected]>
smacker
approved these changes
Jun 28, 2018
There was a problem hiding this comment.
hm. Looks like the issue in code-mirror was fixed: codemirror/codemirror5@3316d35#commitcomment-16278388
let's merge it but keep issue open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#147
Adds the missing scroll in the main query box.
There is, however, a problem I'm not able to fix. The horizontal scroll on firefox covers half of the last line. This does not happen if CodeMirror
lineNumbersis enabled. It might be related to codemirror/codemirror5#3821.Chrome on top, firefox below it: