Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded the plugin so it works with AGP-8.x.x #254

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SSamratR
Copy link

@SSamratR SSamratR commented Jan 2, 2025

This pull request addresses compatibility issues with the Square In-App Payments Flutter SDK on newer versions of Android Gradle Plugin (AGP) and updates the Java implementation to align with the latest Android development standards. Specifically, this PR:

Updates the compileSdk to 35 to ensure compatibility with the latest Android APIs.
Updates the Android Gradle Plugin to version 8.6.0 and JDK to version 17, ensuring compatibility with the latest build tools.
Refactors the CardEntryModule.java to correctly reference style resources, resolving runtime issues related to UI customization.
These updates collectively address and resolve issues #240, #251, and #252, improving the reliability and compatibility of the plugin with modern Android development environments.

Related Issues
Fix #240
Fix #251
Fix #252

Changelog
Android Compatibility:

Updated compileSdk to 35.
Updated AGP to 8.6.0.
Updated JDK to 17.
Java Refactor:

Modified CardEntryModule.java to correctly reference style resources, fixing crashes and inconsistencies in UI rendering.

@SSamratR
Copy link
Author

SSamratR commented Jan 5, 2025

@brandonjenniges hello, can u please review this PR .

Copy link

@shauna-kimura shauna-kimura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants