Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: implement moderator todos #52

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix: implement moderator todos #52

wants to merge 7 commits into from

Conversation

lukealvoeiro
Copy link
Collaborator

What does this PR change

  • Ensures we call rewrite before AND after we get a message from the LLM, meaning at no point will a call to generate ever result in an exchange over the token limit.
    • This means we can correct the max token count to the highest possible setting: 128K
  • Enables usage of an offset in the summarize moderator to

Why?

These two fixes, especially the second one, are required in order to make the summarize moderator the default moderator for an exchange.

@michaelneale michaelneale mentioned this pull request Sep 24, 2024
Closed
michaelneale
michaelneale requested changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@michaelneale michaelneale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't default yet to summarizer as it has a default of gpt4o-mini.

Also #53 - that change should fix the failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelneale michaelneale michaelneale requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukealvoeiro @michaelneale