Fix rule.remove and rule.metric #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The data bound to rule was inconsistently either an integer or an object with an integer attribute i. This affected both rule.remove in that it tried to remove a listener using this data, and the styling of rules drawn from rule.metric (which is apparently undocumented, but super useful)
|
Any feedback on the axis.remove() fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data bound to rule was inconsistently either an integer or an object with
an integer attribute i. This affected both rule.remove in that it tried to
remove a listener using this data, and the styling of rules drawn from
rule.metric which is used to draw rules at specific times to denote events such as deployments (which is apparently undocumented, but super useful). These are the divs classed as "metric line" in the code. This functionality was introduced here c4d23ab
Attached is an example of rules drawn using rule.metric
This pull request picks up of of #40