Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supplementary Tracking Issues Take 2 #520

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Supplementary Tracking Issues Take 2 #520

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0779d5c
Revert "Revert "Supplementary Tracking Fixes (#433)""
kyleve Jan 10, 2024
9f3be3a
Revert weak change
kyleve Jan 10, 2024
c113c84
fix: don't cancel touches in view for tap gesture recognizer
nsillik Jan 11, 2024
8c45c52
Merge branch 'main' into kve/revert-revert-supplementary-tracking
kyleve Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ListableUI/Sources/Internal/ItemCell.ContentViewContainer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ extension ItemCell {
addGestureRecognizer(panGestureRecognizer)
let tapGestureRecognizer = UITapGestureRecognizer(target: self, action: #selector(handleTap))
tapGestureRecognizer.require(toFail: panGestureRecognizer)
tapGestureRecognizer.cancelsTouchesInView = false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this resolve?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that's showing up here, it's in main #521

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh... I wonder if merging main into this would resolve the confusion GitHub's having here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging main in seemed to resolve this, odd

addGestureRecognizer(tapGestureRecognizer)

configurations[side] = SwipeConfiguration(
Expand Down
Loading