Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update workaround versions #506

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Update workaround versions #506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions ListableUI/Sources/ListView/ListView+iOS16.4Workaround.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,10 @@ import UIKit

/// ## ⚠️⚠️⚠️ Good Morning! iOS Bug Workaround Ahead ⚠️⚠️⚠️
///
/// iOS 16.4 introduced a regression, where on every `performBatchUpdates` applied
/// to a `UICollectionView`, it would resign the first responder if it was within a supplementary
/// (header, footer) view. This is a common position for search bars. Regular cells are not affected.
/// iOS 16.4 introduced a regression (which was fixed in 16.5, then again broken in 17.0),
/// where on every `performBatchUpdates` applie to a `UICollectionView`, it would resign
/// the first responder if it was within a supplementary (header, footer) view.
/// This is a common position for search bars. Regular cells are not affected.
///
/// Square SEV: https://jira.sqprod.co/browse/ALERT-11928
///
Expand Down Expand Up @@ -120,8 +121,8 @@ import UIKit
extension ListView {

// Note: If we need additional overrides, please subclass me, so we can
// wholesale delete this subclass when we drop iOS 16.4.
@available(iOS, introduced: 14.0, obsoleted: 16.5, message: "This workaround is no longer applicable. Please remove!")
// wholesale delete this subclass when we drop iOS 17.0.
@available(iOS, introduced: 14.0, obsoleted: 17.0, message: "This workaround is no longer applicable. Please remove!")
class IOS16_4_First_Responder_Bug_CollectionView : UICollectionView {

override init(
Expand Down
Loading