Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force layout before appear, to avoid animated updates #505

Merged
merged 3 commits into from
Sep 20, 2023

Conversation

kyleve
Copy link
Collaborator

@kyleve kyleve commented Sep 12, 2023

Before dequeuing a cell, we'll now force a non-animated layout, to avoid animations occurring during cell reuse.

Checklist

Please do the following before merging:

  • Ensure any public-facing changes are reflected in the changelog. Include them in the Main section.

@kyleve kyleve changed the title [WIP DNR] Force layout before appear, to avoid animated updates Force layout before appear, to avoid animated updates Sep 12, 2023
@kyleve kyleve marked this pull request as ready for review September 12, 2023 18:03
@kyleve kyleve requested a review from a team September 12, 2023 18:04
@kyleve kyleve enabled auto-merge (squash) September 20, 2023 23:23
@kyleve kyleve merged commit ae33952 into main Sep 20, 2023
4 checks passed
@kyleve kyleve deleted the kve/force-layout-before-appear branch September 20, 2023 23:42
kyleve added a commit that referenced this pull request Sep 21, 2023
kyleve added a commit that referenced this pull request Nov 19, 2023
…rovements

* origin/main: (123 commits)
  Update CHANGELOG.md (#508)
  Revert "Supplementary Tracking Fixes (#433)"
  Revert "Force layout before appear, to avoid animated updates (#505)"
  Force layout before appear, to avoid animated updates (#505)
  Update workaround versions (#506)
  Fix supplementary view + contained first responder reuse issue (#507)
  Supplementary Tracking Fixes (#433)
  Release 13.0.0 (#504)
  Update KeyboardObserver (#499)
  CONV-1435: Gravity layout frame change fix - Before: Layout gravity doesn't take into account frame changes. For example, when the orientation changes the scroll position (relative to the bottom) changes - After: Layout gravity takes frame changes into account so the when the frame changes the scroll position relative to the bottom remains unchanged
  Release 12.0.0 (#501)
  CONV-1435: Add scroll indicator insets to customScrollViewInsets (#500)
  CONV-1435: Gravity layout - Adds a new Chat App demo and a new behavior called verticalLayoutGravity.  When verticalLayoutGravity is set to bottom, scrolling works the way you would expect for a messaging app.
  expose onKeyboardFrameWillChange on ListProperties
  onKeyboardFrameWillChange: Improve CHANGELOG, DocC
  CONV-1435: Custom keyboard adjustment mode - Adds a .custom KeyboardAdjustmentMode to fully customize inset behavior
  remove contentOffset from isContentScrollable calculation, improve comment
  Add ListView#isContentScrollable property - Add this property to ListView. It will be used in conjunction with upcoming so-called gravity scrolling changes to workaround an animation issue with paging
  Update CI script to reference the `xcodesorg/made/xcodes` package for installing simulator runtimes. (#494)
  Swipe Action Updates (#489)
  ...
kyleve added a commit that referenced this pull request Dec 8, 2023
…rements

* origin/main:
  Update CHANGELOG.md
  Allow other panning to work on other cells while another is open
  Remove `isTouchWithinSwipeActionView`
  Update swipe actions to more closely match iOS behavior
  Update CHANGELOG.md
  Release 13.1.0
  Only return existing view if there is a contained first responder
  Self code review
  Fixed an issue where a crash would occur when applying an external update to list content while a live reorder event was occurring.
  Remove override of performBatchUpdates, it causes warnings for consumers
  Update CHANGELOG.md (#508)
  Revert "Supplementary Tracking Fixes (#433)"
  Revert "Force layout before appear, to avoid animated updates (#505)"
kyleve added a commit that referenced this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants