Skip to content

Commit

Permalink
Update workaround versions (#506)
Browse files Browse the repository at this point in the history
Fix messaging for version workarounds; this is still broken in 17 RC
  • Loading branch information
kyleve authored Sep 20, 2023
1 parent df73699 commit 60f5e89
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions ListableUI/Sources/ListView/ListView+iOS16.4Workaround.swift
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,10 @@ import UIKit

/// ## ⚠️⚠️⚠️ Good Morning! iOS Bug Workaround Ahead ⚠️⚠️⚠️
///
/// iOS 16.4 introduced a regression, where on every `performBatchUpdates` applied
/// to a `UICollectionView`, it would resign the first responder if it was within a supplementary
/// (header, footer) view. This is a common position for search bars. Regular cells are not affected.
/// iOS 16.4 introduced a regression (which was fixed in 16.5, then again broken in 17.0),
/// where on every `performBatchUpdates` applie to a `UICollectionView`, it would resign
/// the first responder if it was within a supplementary (header, footer) view.
/// This is a common position for search bars. Regular cells are not affected.
///
/// Square SEV: https://jira.sqprod.co/browse/ALERT-11928
///
Expand Down Expand Up @@ -120,8 +121,8 @@ import UIKit
extension ListView {

// Note: If we need additional overrides, please subclass me, so we can
// wholesale delete this subclass when we drop iOS 16.4.
@available(iOS, introduced: 14.0, obsoleted: 16.5, message: "This workaround is no longer applicable. Please remove!")
// wholesale delete this subclass when we drop iOS 17.0.
@available(iOS, introduced: 14.0, obsoleted: 17.0, message: "This workaround is no longer applicable. Please remove!")
class IOS16_4_First_Responder_Bug_CollectionView : UICollectionView {

override init(
Expand Down

0 comments on commit 60f5e89

Please sign in to comment.