Add Fluid codegen #2077
Merged
Add Fluid codegen #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typhoonzero
reviewed
Apr 1, 2020
pkg/workflow/fluid/codegen.go
Outdated
| } | ||
|
|
||
| // MockSQLProgramIR mock a SQLFLow program which contains multiple statements | ||
| func MockSQLProgramIR() []ir.SQLFlowStmt { |
There was a problem hiding this comment.
Put this in the _test.go file should be cool.
There was a problem hiding this comment.
the function in _test.go can not be used as a public function, I prefer in codegen.go.
typhoonzero
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue #1980
This PR implements
fluid/codegen.goto generate a Fluid program.The generated YAML file is not valid, some TODO tasks should be fixed:
sql-machine-learning/fluid#24
sql-machine-learning/fluid#23