forked from gwastro/pycbc
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cupy decompress module #38
Open
GarethCabournDavies
wants to merge
20
commits into
spxiwh:pr_prototype_cupy_backend
Choose a base branch
from
GarethCabournDavies:pr_prototype_cupy_backend
base: pr_prototype_cupy_backend
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add cupy decompress module #38
GarethCabournDavies
wants to merge
20
commits into
spxiwh:pr_prototype_cupy_backend
from
GarethCabournDavies:pr_prototype_cupy_backend
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…encies (gwastro#4948) * added a feature to generate frequency domain waveforms at reduced frequencies * Mofified the input argument --full-resolution-buffer-length and fixed some bugs * Minor change * Minor change * updated the help message for --buffer-high-pass-length --------- Co-authored-by: Kanchan Soni <[email protected]>
…coh_ifosnr` (gwastro#4950) * Version of pycbc_pygrb_plot_chisq_veto with vetoes (albeit with a mute apply_vetoes_to_found_injs for the time being) * Version of pycbc_pygrb_plot_coh_ifosnr with vetoes (albeit with a mute apply_vetoes_to_found_injs for the time being) * Update f-string in pycbc_pygrb_plot_coh_ifosnr Co-authored-by: Tito Dal Canton <[email protected]> * Update f-string in pycbc_pygrb_plot_chisq_veto Co-authored-by: Tito Dal Canton <[email protected]> * Update f-string in pycbc_pygrb_plot_chisq_veto Co-authored-by: Tito Dal Canton <[email protected]> * Update f-string in pycbc_pygrb_plot_chisq_veto Co-authored-by: Tito Dal Canton <[email protected]> * Comment corrected * Removed dof_key variable * Update bin/pygrb/pycbc_pygrb_plot_chisq_veto Co-authored-by: Tito Dal Canton <[email protected]> * numpy.where --> numpy.nonzero in pycbc_pygrb_plot_coh_ifosnr Co-authored-by: Tito Dal Canton <[email protected]> * senstvty --> sensitivity * Comprehension for dictionary generation * Removed try-except * Improved comments --------- Co-authored-by: Tito Dal Canton <[email protected]>
* get singles back to being reduced chisquared in uploads * Save ranking statistic information in the "likelihood" part of the coinc table * Not all CandidateForGraceDB will have stat in the coinc_results
* Handling new option for pycbc_pygrb_plot_snr_timeseries jobs * Avoid single use of variable
…astro#4961) * Converting indexes of triggers into np.int32 because of numpy 2.x * Minor changes only for comment lines --------- Co-authored-by: jacquot <jacquot@>
Thanks! But rather than merging into an existing PR (which then needs someone else to review), can we merge the PR onto the main branch first, and then merge this? |
GarethCabournDavies
force-pushed
the
pr_prototype_cupy_backend
branch
2 times, most recently
from
November 29, 2024 12:32
d0ff667
to
99c3770
Compare
* Version of pycbc_pygrb_plot_injs_results * Update bin/pygrb/pycbc_pygrb_plot_injs_results Co-authored-by: Marco Cusinato <[email protected]> * Update bin/pygrb/pycbc_pygrb_plot_injs_results Co-authored-by: Marco Cusinato <[email protected]> * Small optimization: awqvoid calculating eta and not using it * Removing redundant slicings; introducing auxiliary vars for readability; fixing background array * Removed redundant line --------- Co-authored-by: Marco Cusinato <[email protected]>
…ata (gwastro#4959) * Added --fake-strain-from-file and channel names/frame types for O4 * Update pycbc_make_skymap with Tito suggestions --------- Co-authored-by: Amazigh Ouzriat <[email protected]> Co-authored-by: Amazigh Ouzriat <[email protected]>
* Developing GPU CUPY backend * Don't import aligned!! * Adding cupy FFT to scheme * Don't understand why copy here?? * Get right memory pointer * Add CUPY scheme to CLI * Typo in scheme.py * Remove warning * Adding some more array stuff * The i is kind of important for a phase shift!! * Add device num support * Set device number * Add prototype spa_tmplt_cupy * Adding new parts of CUPY backend * Typo in scheme.py * Need to force numpy in PSD estimate * Add SPATmplt in waveform.py * Starting to understand RawKernel and CUDA * Remove print statement * Force numpy returns * Gareth's comments * Try to fix test suite * Refactor LAL constants * Probably need BBHx * Move cupy array decleration to when needed * Typo * Don't want time-reversed waveforms! * Add FIXME * Testing chisq optimization - DO NOT MERGE * Revert "Testing chisq optimization - DO NOT MERGE" This reverts commit 62a59e5. * Add deprecated warning
…le (gwastro#4965) * Allow units for --ra and --dec, improve external trigger info table * Fix thinko
GarethCabournDavies
force-pushed
the
pr_prototype_cupy_backend
branch
from
December 4, 2024 16:21
99c3770
to
61d9f5d
Compare
* Fixing overlaping sections bug * Reading before environment section is set to avoid errors * skipping environment section * read the file before environment * removing reading with parser * making parser case sensitive --------- Co-authored-by: Aleyna Akyuz <[email protected]> Co-authored-by: Aleyna Akyuz <[email protected]>
…tro#4977) * Corrected background and module path * Variable for readability
* Vetoes in pycbc_pygrb_page_tables + some syntax streamlining * Vetoes in pycbc_pygrb_efficiency + some syntax streamlining * Squashed mchirp retrieval bug in page_tables * PR review follow up: comprehension, comment, readability, unused variables * Cleaner format_pvalue_str * Cleaner comprehensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.