Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework entrypoint to deprecate some variables #72

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Adam-Ant
Copy link
Member

@Adam-Ant Adam-Ant commented Apr 30, 2024

Needs deprecation warning for NO_LICENSE_KEY, & LICENSE_KEY (and gentle prods towards the associated config options)

@Adam-Ant Adam-Ant requested a review from frebib April 30, 2024 21:16
@Adam-Ant Adam-Ant marked this pull request as draft April 30, 2024 21:16
entrypoint Outdated Show resolved Hide resolved
entrypoint Outdated Show resolved Hide resolved
>&2 printf "txadmin does not use the \$LICENSE_KEY environment variable.\nPlease remove it and set it through the txadmin web UI\n\n"
exit 1
# Set some default options.
if [ -z "${NO_DEFAULT_CONFIG}" ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If NO_TXADMIN is set explicitly by the user, we shouldn't do this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants