Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support @LoadBalanced RestTemplateBuilder #1403

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Support @LoadBalanced RestTemplateBuilder #1403

merged 4 commits into from
Oct 15, 2024

Conversation

OlgaMaciaszek
Copy link
Collaborator

Fixes gh-1402

@OlgaMaciaszek OlgaMaciaszek self-assigned this Oct 11, 2024
@OlgaMaciaszek OlgaMaciaszek marked this pull request as ready for review October 14, 2024 19:06
spencergibb
spencergibb approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@spencergibb spencergibb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To summarize, you took the rest template post processor, pulled out the common bits into an abstract base class then added the rest template builder support. Did I get that right?

@OlgaMaciaszek
Copy link
Collaborator Author

To summarize, you took the rest template post processor, pulled out the common bits into an abstract base class then added the rest template builder support. Did I get that right?

Yes, just it was the RestClient.Builder post-processor.

@OlgaMaciaszek OlgaMaciaszek merged commit 2cf7717 into main Oct 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencergibb spencergibb spencergibb approved these changes

@ryanjbaxter ryanjbaxter ryanjbaxter approved these changes

Assignees

@OlgaMaciaszek OlgaMaciaszek

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support @LoadBalanced RestTemplateBuilder
3 participants
@OlgaMaciaszek @ryanjbaxter @spencergibb