-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for reactive Resilience4jBulkheadProvider to provide bulkhead support for reactive operations (Mono and Flux). #231
base: main
Are you sure you want to change the base?
Conversation
…head support for reactive operations (Mono and Flux).
…head support for reactive operations (Mono and Flux).
…head support for reactive operations (Mono and Flux).
Thanks! This is great! If you would like we could merge this into our next minor release but we would have to rework the PR a bit to remove any kind of breaking changes to the APIs (changes to public method signatures). If not we can wait till the next major to merge it (which would be in a few months). Either way it would be nice to add some documentation about the reactive support. |
…head support for reactive operations (Mono and Flux).
Thanks for the feedback! I prefer to merge this into your next minor release. I have reworked the PR by adding additional constructors instead of changing the existing public method signatures. The only place a public method signature (bean declaration) is changed is inside the Should I create a separate bean method that includes the Also, I agree to document that change. |
No for the configuration class you can change that public method. Just mark the old constructors as |
…head support for reactive operations (Mono and Flux).
I annotated the old constructors with |
Just for clarification, when are you planning your next minor release? |
Watch here for updates. We're doing some planning very soon and will add a date there. |
After discussing scheduling with the team, the next minor will be in the June timeframe. You can keep an eye on our milestone dates for the most up to date information. That said we will likely merge this before the end of the month once we have a branch. |
Add support for reactive Resilience4jBulkheadProvider
ReactiveResilience4jBulkheadProvider
to provide bulkhead support for reactive operations (Mono and Flux).SemaphoreBulkhead
to enforce concurrency limits.ReactiveResilience4jBulkheadProvider
into therun
methods forMono
andFlux
to handle bulkhead constraints, along with optional CircuitBreaker and TimeLimiter configurations.run
methods:Mono<T>
:bulkheadProvider.decorateMono
method decorates the Mono with bulkhead protection.CircuitBreakerOperator
).Flux<T>
:SemaphoreBulkhead
is used for reactive scenarios sinceFixedThreadPoolBulkhead
is not supported.This MR addresses issues #166 and #105 by introducing ReactiveResilience4jBulkheadProvider for handling bulkhead constraints in reactive streams.
Refs #166, #105