Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for current_user_top_artists #1171

Merged
merged 4 commits into from
Jan 12, 2025

Conversation

s2t2
Copy link
Contributor

@s2t2 s2t2 commented Nov 27, 2024

Update docs to include the maximum value for limit parameter of Client.current_user_top_artists method.

See: https://developer.spotify.com/documentation/web-api/reference/get-users-top-artists-and-tracks

@s2t2 s2t2 changed the title Update docs Update docs for current_user_top_artists Nov 28, 2024
@dieser-niko
Copy link
Member

I think we should add the limits to all docstrings with a limit defined. It's already pretty inconsistent, so this PR might be a good way to fix this. If you want to, you can already start.

@stephanebruckert
Copy link
Member

I think we should add the limits to all docstrings with a limit defined. It's already pretty inconsistent, so this PR might be a good way to fix this. If you want to, you can already start.

To clean up PRs, let's merge it as it's already useful, and I've added a comment about it in #652 (comment)

@stephanebruckert stephanebruckert merged commit ca207e4 into spotipy-dev:master Jan 12, 2025
6 checks passed
508chris pushed a commit to 508chris/spotipy that referenced this pull request Jan 13, 2025
* Update docs

Add maximum value for limit parameter. See: https://developer.spotify.com/documentation/web-api/reference/get-users-top-artists-and-tracks

* Update CHANGELOG.md

---------

Co-authored-by: Stéphane Bruckert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants