Fix SMB producer compatibility issues (#4667)

* Fix SMB producer compatibility issues * Set smb compatibility test same as 0.11 * Keep old compat check * Restore test for compatibility check * javafmt Co-authored-by: Michel Davit <[email protected]>
spotify · Jan 25, 2023 · dcaac2b · dcaac2b
1 parent 340509f
commit dcaac2b
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/scio-smb/src/main/java/org/apache/beam/sdk/extensions/smb/BucketMetadata.java b/scio-smb/src/main/java/org/apache/beam/sdk/extensions/smb/BucketMetadata.java
@@ -75,7 +75,14 @@
 @JsonTypeInfo(use = JsonTypeInfo.Id.CLASS, include = JsonTypeInfo.As.PROPERTY, property = "type")
 public abstract class BucketMetadata<K1, K2, V> implements Serializable, HasDisplayData {
 
-  @JsonIgnore public static final int CURRENT_VERSION = 1;
+  /**
+   * The VERSION parameter is included in the metadata.json file for every SMB. Take extreme care in
+   * bumping version: Scio versions prior to 0.12.1 perform a version compatibility check on SMB
+   * partitions which may fail if the SMB producer bumps to an incompatible version.
+   *
+   * <p>The next version bump should be to: 2
+   */
+  @JsonIgnore public static final int CURRENT_VERSION = 0;
 
   // Represents the current major version of the Beam SMB module. Storage format may differ
   // across versions and require internal code branching to ensure backwards compatibility.