fix: TypeMismatch doesn't trigger apply #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziodemaria
requested review from
mfranberg,
vahidlazio,
nicklasl and
nickybondarenko
as code owners
fabriziodemaria
force-pushed
the
fix-applies
branch
from
0380970
to
f4cec47
Compare
fabriziodemaria
force-pushed
the
fix-applies
branch
from
f4cec47
to
0b00f97
Compare
fabriziodemaria
changed the title
fabriziodemaria
changed the title
fabriziodemaria
force-pushed
the
fix-applies
branch
from
7fb4010
to
1cd12a7
Compare
fabriziodemaria
commented
Nov 6, 2024
| @@ -285,6 +285,46 @@ class ConfidenceTest: XCTestCase { | |||
| XCTAssertEqual(flagApplier.applyCallCount, 1) | |||
| } | |||
|
|
|||
| func testResolveAndApplyIntegerFlagNullValue() async throws { | |||
There was a problem hiding this comment.
This test is unrelated to the fix, but nice to have
fabriziodemaria
commented
Nov 6, 2024
fabriziodemaria
commented
Nov 7, 2024
fabriziodemaria
force-pushed
the
fix-applies
branch
from
bfe59c7
to
632c3bf
Compare
nicklasl
reviewed
Nov 7, 2024
nicklasl
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #170