chore: preparation to NPM publish #1511
Open
+215
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viktor Tsvetkov <[email protected]>
Signed-off-by: Viktor Tsvetkov <[email protected]>
Signed-off-by: Viktor Tsvetkov <[email protected]>
| "license": "Apache-2.0", | ||
| "private": true, | ||
| "author": "Splunk Inc.", |
There was a problem hiding this comment.
Should we add this one?
| "name": "@splunk/ucc_ui_lib", | ||
| "version": "0.0.1", | ||
| "name": "@splunk/add-on-ucc-framework", | ||
| "description": "Splunk Add-on SDK formerly UCC is a build and code generation framework", |
| ) => CustomTabInstance<T>; | ||
|
|
||
| export abstract class CustomTabBase { | ||
| protected tab: object; |
There was a problem hiding this comment.
maybe lets add a type for this one?
| const customControl = new Control( | ||
| globalConfig, | ||
| this.el, | ||
| this.props.data, | ||
| this.setValue, | ||
| this.props.utilCustomFunctions | ||
| ); | ||
| customControl?.render(); | ||
| customControl.render(); |
There was a problem hiding this comment.
to not change behaviour, should we validate if that one exists?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: ADDON-76791
PR Type
What kind of change does this PR introduce?
Summary
Changes
User experience
There is no impact on the app logic. Except there was a missing groupName param for CustomHookConstructor: ui/src/components/BaseFormView/BaseFormView.tsx:1108
Checklist
If an item doesn't apply to your changes, leave it unchecked.