Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add basic icons #1498

Merged
merged 7 commits into from
Dec 11, 2024
Merged

feat: add basic icons #1498

merged 7 commits into from
Dec 11, 2024

Conversation

hetangmodi-crest
Copy link
Contributor

Issue number: ADDON-76502

PR Type

What kind of change does this PR introduce?

  • Feature
  • Bug Fix
  • Refactoring (no functional or API changes)
  • Documentation Update
  • Maintenance (dependency updates, CI, etc.)

Summary

Added default icons after ucc-gen init command.

Changes

After running ucc-gen init command the add-on will have 6 basic images, that are appIcon.png, appIcon_2x.png, appIconAlt.png, appIconAlt_2x.png, appLogo.png, appLogo_2x.png

User experience

User will have these basic images after initializing the add-on.

Checklist

If an item doesn't apply to your changes, leave it unchecked.

@hetangmodi-crest hetangmodi-crest added the enhancement New feature or request label Dec 2, 2024
@hetangmodi-crest hetangmodi-crest self-assigned this Dec 2, 2024
@hetangmodi-crest hetangmodi-crest marked this pull request as ready for review December 2, 2024 13:38
@hetangmodi-crest hetangmodi-crest requested a review from a team as a code owner December 2, 2024 13:38
@vtsvetkov-splunk
Copy link
Contributor

should we remove an ignored issue from conftest.py then?

appLogo.png - Failed to load resource: the server responded with a status of 404 (Not Found)

@pull-request-size pull-request-size bot added size/M and removed size/S labels Dec 10, 2024
@hetangmodi-crest
Copy link
Contributor Author

Removed the ignored issue from conftest.py

@hetangmodi-crest hetangmodi-crest merged commit b07657d into develop Dec 11, 2024
98 checks passed
@hetangmodi-crest hetangmodi-crest deleted the feat/add-basic-icons branch December 11, 2024 13:03
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants