-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard): zero line when no data found #1480
feat(dashboard): zero line when no data found #1480
Conversation
278b327
to
2cdd407
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (I have no understanding of the magic symbol combination). Could you add more context to the description what changed high level? I see you enabled smart search. It would be nice to see the reasoning, what the pros and cons of this. Would it work slower/faster; cost more/less
This reverts commit e2a64e6.
9354164
to
937ec0e
Compare
I added some more descriptions, let me know if thats enough. Generally the benefit is it looks a bit better but cons are only some potential cost, which should be close to 0, as those are static computations in the end. |
Issue number:
https://splunk.atlassian.net/browse/ADDON-76195
PR Type
What kind of change does this PR introduce?
Summary
Zero line is displayed when no data found for all dashboard charts, except those in resource tab.
Pros:
Cons:
Sum up:
Comparing to data search this operation shouldn't be a problem.
Some info regarding Smart Sources (https://splunkui.splunk.com/Packages/dashboard-docs/Smartsources ).
it is a feature that enables referencing already finished search jobs and its results inside next searches (here it is used to verify if there are any results for table data, if not then default values are applied if there are next code is ignored).
Changes
For data charts where "No data found" message is displayed there is displayed chart with zero line, simulating none of the events to appear.
User experience
Please describe the user experience before and after this change. Screenshots are welcome for additional context.
Overview before changes:
Overview after changes:
Data Ingestion tab before changes:
Data Ingestion tab after changes:
Error tab before changes:
Error tab after changes:
Tables for errors is filled with 0 data when data volume found but number of events got no data.
Resource consumption tab after changes remains the same:
Checklist
If an item doesn't apply to your changes, leave it unchecked.