Cleanup #627
Draft
Cleanup #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GPMueller
force-pushed
the
feature-ci-linting
branch
24 times, most recently
from
4cba9a3 to
24c4cc3
Compare
muellan
force-pushed
the
develop
branch
2 times, most recently
from
8681009 to
8702cb4
Compare
muellan
force-pushed
the
develop
branch
7 times, most recently
from
63fbd74 to
2edff73
Compare
- remove all methods' pre-iteration hook - rename `Hook_Post_Iteration` to `Post_Iteration_Hook` - move `Method::Initialize` to `Method_Solver::Initialize_Solver` - moved initialization of `noi` and `nos` to `Method` constructor and moved the `Initialize_Solver` call to only occur in the `Method_s - replaced some throwing functions in `Method` with deleted (declared `= 0`), namely those which _have to_ be overridden anyways - improved some initializations - replaced some `new`s in `std::shared_ptr` constructors with `std::make_shared` - added `const` to some `auto &`s
- more `const`ifying `auto &`s - replacing `push_back`s with `emplace_back`s
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #627 +/- ##
========================================
Coverage 48.64% 48.64%
========================================
Files 77 77
Lines 13041 13041
========================================
Hits 6344 6344
Misses 6697 6697 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some tidying up:
Hook_Pre_Iterationconsthere and therestd::make_sharedmore