fix(orca-sql): Add migration for mariadb support #4779
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contribution was discussed in this slack thread:
https://spinnakerteam.slack.com/archives/C7J1CU4LA/p1722343931881969?thread_ts=1710447204.964799&cid=C7J1CU4LA
In summary:
The migration in
20201214-create-compressed-executions-table.yaml
that is adding the columncompression_type
is not being ran for MariaDB because it containsdbms: mysql
. This causes Orca to throw the following error on startup if using MariaDB:This happens because, since the column is not being created on that migration, the Postgres migration is ran because of this conditional:
orca/orca-sql/src/main/resources/db/changelog/20220427-add-compression-type-column-to-compressed-executions-tables-postgres.yaml
Lines 13 to 18 in ad53c17
And running the Postgres migration on MariaDB causes the error to appear. The solution for this is to create a new migration for MariaDB that is executed before the Postgres migration that adds the column only if using MariaDB. We can't change previous migrations because the changeset hash would change and would start failing for everyone who already applied it.
Spinnaker should be able to support MariaDB as there are mentions in the documentation:
https://spinnaker.io/docs/setup/productionize/persistence/orca-sql/#mariadb