fix(expressions): fetch labels from actually deployed manfiest #4508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattgogerly
force-pushed
the
fix-manifest-label-value-expression
branch
from
3b0bb9f
to
94b1790
Compare
dbyron-sf
reviewed
Aug 21, 2023
| // deployment | ||
| // this is safe as we assert above that we're only using successful deploy stages, so this key | ||
| // should always exist | ||
| List<Map> manifests = (List<Map>) stage.get().getContext().get("outputs.manifests"); |
There was a problem hiding this comment.
Is this safe timing-wise? Like, could this run when manifests exists, but output.manifests doesn't?
There was a problem hiding this comment.
I'm reasonably confident outputs.manifests should always exist once a deploy stage is succeeded - and this expression only considers stages in a succeeded state.
There was a problem hiding this comment.
Aaah, I see it a few lines up.
dbyron-sf
approved these changes
Aug 22, 2023
|
@Mergifyio update |
✅ Branch has been successfully updated |
mattgogerly
added a commit
to mattgogerly/spinnaker.io
that referenced
this pull request
Aug 24, 2023
Release preview for spinnaker/orca#4508
dbyron-sf
pushed a commit
to spinnaker/spinnaker.io
that referenced
this pull request
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a use case where we want to make a stage conditional based on the value of the sequence label. This label isn't present in the
manifestsfield of the context, because it's only applied during deployment by Clouddriver.The
outputs.manfiestsfield contains the full Kubernetes manifests that were deployed by Clouddriver, including labels added by Spinnaker during deployment. This should be a backwards compatible change, as the labels in themanifestsfield are obviously also included in theoutputs.manfiestsfield.I would have preferred to make this change optional using a default function argument of false, but it seems the
FunctionParameterclass has no concept of a default value.