Enable loading static assets in Spin applications #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables loading static assets in Spin applications. Specifically, it modifies the engine to check for the Spin static asset media type and adds that layer to the Spin cache, used later by the loader. Signed-off-by: Radu Matei <[email protected]> Co-authored-by: Kate Goldenring <[email protected]> Co-authored-by: Vaughn Dice <[email protected]>
Signed-off-by: Kate Goldenring <[email protected]>
radu-matei
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
I know @Mossaka was interested in adding a test for this, but I think we can do that in a follow-up.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables loading static assets in Spin applications.
Specifically, this modifies the engine to check for the Spin static asset
media type and adds that layer to the Spin cache, used later by the loader.